[DRAFT] Moving dependency of mssql to the it module.
#2076
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VardhanThigle
changed the title
mssql to the it module.mssql to the it module.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2076 +/- ##
============================================
+ Coverage 46.31% 46.33% +0.02%
- Complexity 3919 4251 +332
============================================
Files 857 857
Lines 51215 51240 +25
Branches 5389 5390 +1
============================================
+ Hits 23719 23741 +22
- Misses 25783 25785 +2
- Partials 1713 1714 +1
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
The missing dependency on
mssqlcaused integration test failure on #2064Ref-of-the-run
It's possible that it worked for so many days due to the dependency being cached on the runners.
In order to unblock the
sourcedb-to-spannerchanges faster, the dependency was introduced only inv2/sourcedb-to-spannerMoving it to the JDBCBaseIT package, where the jar is copied to GCS.